Wireshark mailing list archives
Re: Handling TCP packets reordering
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Sat, 7 May 2011 12:26:31 +0200
On Wed, May 04, 2011 at 10:27:32PM +0200, Sake Blok wrote:
On 4 mei 2011, at 22:11, Jeff Morriss wrote:I would think desegment_tcp() should be able to handle this by not calling your dissector for an out-of-order segment:it should be able to only call your dissector once it has a completely reassembled (desegmented) PDU. Looking through the code, it's not immediately obvious to me what the problem is. One case that can cause a problem is when the first segment of a PDU is received out-of-order.
Can we test when creating PDU if created PDU overlaps with another one? Attaching PoC.
Attachment:
pdu-overlaps-test.patch
Description:
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Handling TCP packets reordering Max Dmitrichenko (May 04)
- Re: Handling TCP packets reordering Mikko Saarnivala (May 04)
- Re: Handling TCP packets reordering Jeff Morriss (May 04)
- Re: Handling TCP packets reordering Sake Blok (May 04)
- Re: Handling TCP packets reordering Jeff Morriss (May 04)
- Re: Handling TCP packets reordering Max Dmitrichenko (May 04)
- Re: Handling TCP packets reordering Sake Blok (May 04)
- Re: Handling TCP packets reordering Jeff Morriss (May 04)
- Re: Handling TCP packets reordering Sake Blok (May 04)
- Re: Handling TCP packets reordering Sake Blok (May 04)
- Re: Handling TCP packets reordering Jakub Zawadzki (May 07)
- Re: Handling TCP packets reordering Jeff Morriss (May 04)
- Re: Handling TCP packets reordering Max Dmitrichenko (May 04)