Re: Some Sub-Tlvs description in FEC Stack are nonuniform with RFC4379.

[Jaap Keuter <jaap.keuter () xs4all nl>]

Hi, 

You're welcome to file a bug report at bugs.wireshark.org,
where you can add a patch as well if you like. 

Thanks,
Jaap 

On Wed,
11 May 2011 00:19:10 -0700, Liu, Pengfei (Jeff) wrote: 

> Hi , 
The Sub-Type in FEC Stack is defined in RFC4379 as follow: 
>
Sub-Type Length Value Field 
> -------- ------ ----------- 
>
> …………

> _ 9 10 "FEC 128" Pseudowire (deprecated) _-----current name__ 

> _ 10 14 "FEC 128" Pseudowire _ 
>
> 11 16+ "FEC 129" Pseudowire 

> ………… 
>
> 0 1 2 3
>
> 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2
3 4 5 6 7 8 9 0 1
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |
Remote PE Address |
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |
PW ID |
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |
PW Type | Must Be Zero |
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
FEC 128 Pseudowire (Deprecated) 
> 0 1 2 3
>
> 0 1 2 3 4 5 6 7 8 9 0
1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |
Sender's PE Address |
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |
Remote PE Address |
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |
PW ID |
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> |
PW Type | Must Be Zero |
>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
FEC 128 Pseudowire 
> But in packet-mpls-echo.c:209, It is defined
as: 
> …………. 
>
> _#define TLV_FEC_STACK_L2_CID_OLD 9 _-----CID? old
name?__ 
> _#define TLV_FEC_STACK_L2_CID_NEW 10_ 
>
> …………. 
And the hf is defined like this: 
> …………. 
/*packet-mpls-echo.c:1219*/ 
> { &hf_mpls_echo_tlv_fec_l2cid_sender,

> { "Sender's PE Address", "mpls_echo.tlv.fec.l2_CID_SENDER_", 
FT_IPv4, BASE_NONE, NULL, 0x0, "MPLS ECHO TLV FEC Stack L2_CID SENDER_",
HFILL} 
> }, 
>
> { &hf_mpls_echo_tlv_fec_l2cid_remote, 
>
> {
"Remote PE Address", "mpls_echo.tlv.fec.l2_CID_REMOTE_", 
> FT_IPv4,
BASE_NONE, NULL, 0x0, "MPLS ECHO TLV FEC Stack L2_CID REMOTE_", HFILL}

> }, 
>
> { &hf_mpls_echo_tlv_fec_l2cid_vcid, 
>
> { "VC ID",
"mpls_echo.tlv.fec.l2cid_vcid", 
> FT_UINT32, BASE_DEC, NULL, 0x0,
"MPLS ECHO TLV FEC Stack L2_CID VCID_", HFILL} 
> }, 
>
> …………. 

> For example, the_ CID VCID_ should be_ 'PW ID' OF FEC 128 _rather
than some old or invalid alias. 
> This may confuse the users. 
Best Regards, 
> Jeff 
>
> E-mail confidentiality.
--------------------------------
> This e-mail contains confidential and
/ or privileged information belonging to Spirent Communications plc, its
affiliates and / or subsidiaries. If you are not the intended recipient,
you are hereby notified that any disclosure, copying, distribution and /
or the taking of any action based upon reliance on the contents of this
transmission is strictly forbidden. If you have received this message in
error please notify the sender by return e-mail and delete it from your
system. 
> Spirent Communications plc,
> Northwood Park, Gatwick
Road, Crawley, West Sussex, RH10 9XN, United Kingdom.
> Tel No. +44 (0)
1293 767676
> Fax No. +44 (0) 1293 767677
>
> Registered in England
Number 470893
> Registered at Northwood Park, Gatwick Road, Crawley,
West Sussex, RH10 9XN, United Kingdom.
> Or if within the US,
Spirent Communications,
> 26750 Agoura Road, Calabasas, CA, 91302,
USA.
> Tel No. 1-818-676- 2300

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe