Wireshark mailing list archives
Re: Finding duplicate (conflicting) value_string entries
From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Wed, 18 May 2011 13:36:11 -0400
Jakub Zawadzki wrote:
On Wed, May 18, 2011 at 05:10:09PM +0100, Martin Mathieson wrote:On Wed, May 18, 2011 at 4:49 PM, Jakub Zawadzki <nospam> wrote:This patch is OK for me.I didn't measure, but it didn't noticibly add to the startup timeThis O(n^2) loop sucks a little, you can optimized it with some hashing or bit-setting/checking. But really please don't care about startup-time. It's not so important.
Well, I'd disagree with startup time not being important... :-) I sometimes start Wireshark many times a day, sometimes on not-very-fast SPARCs.
probably not many non-developers run wireshark that way though. I wasn't planning on submitting it in its current form.I think non-developers really don't care about whole tmp_fld_check_assert() check, so one extra is good (and yours patch is really cool). tmp_fld_check_assert() probably should be #ifdef-ed in some MAINTAINER_BUILD (or #ifndef RELEASE_BUILD)
I'd thought of that before, but we definitely want it enabled for all non-release builds (some of those checks save you a crash later on). Even the first compiles in the release builds should have it enabled to ensure ft sanity.
And, these days, these checks are also useful for scripters (Lua or Python); see bug 5930 for an example of where the Lua error checking hadn't kept up with the tmp_fld_check_assert() checking.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Finding duplicate (conflicting) value_string entries Martin Mathieson (May 18)
- Re: Finding duplicate (conflicting) value_string entries Alexis La Goutte (May 18)
- Re: Finding duplicate (conflicting) value_string entries Jakub Zawadzki (May 18)
- Re: Finding duplicate (conflicting) value_string entries Martin Mathieson (May 18)
- Re: Finding duplicate (conflicting) value_string entries Jakub Zawadzki (May 18)
- Re: Finding duplicate (conflicting) value_string entries Jeff Morriss (May 18)
- Re: Finding duplicate (conflicting) value_string entries Jeff Morriss (May 18)
- Re: Finding duplicate (conflicting) value_string entries Martin Mathieson (May 18)
- Re: Finding duplicate (conflicting) value_string entries Jakub Zawadzki (May 18)
- Re: Finding duplicate (conflicting) value_string entries Alexis La Goutte (May 18)
- <Possible follow-ups>
- Re: Finding duplicate (conflicting) value_string entries Ed Beroset (May 18)
- Dynamically loading all dissectors (was: Re: Finding duplicate (conflicting) value_string entries) Stephen Fisher (May 31)
- Re: Dynamically loading all dissectors (was: Re: Finding duplicate (conflicting) value_string entries) Jakub Zawadzki (May 31)
- Re: Dynamically loading all dissectors Anders Broman (May 31)
- Re: Dynamically loading all dissectors Jakub Zawadzki (May 31)
- Dynamically loading all dissectors (was: Re: Finding duplicate (conflicting) value_string entries) Stephen Fisher (May 31)