Wireshark mailing list archives
Re: How to handle Ethernet frames with FCS, malformed packet in PN dissector
From: Guy Harris <guy () alum mit edu>
Date: Mon, 26 Sep 2011 13:55:36 -0700
On Sep 26, 2011, at 12:34 PM, Guy Harris wrote:
Yes - it's assuming that it's being handed a tvbuff containing the FCS, *even if the dissector for the link layer knows that there's an FCS*. That's not what link-layer dissectors should be doing; there was a bug, introduced a while ago, where the Ethernet dissector wasn't removing the FCS if it knew it was there, so perhaps that code was written during the period where that bug was present. I will remove that code from the PN dissector and leave behind a comment explaining why there is no FCS handling code there.
OK, done. Try it with the current SVN version of Wireshark. BTW, is there a spec available for PROFINET Real-Time packets, for non-PROFINET members, either for free or for a not-too-high fee? ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- How to handle Ethernet frames with FCS, malformed packet in PN dissector HPfrommer (Sep 26)
- Re: How to handle Ethernet frames with FCS, malformed packet in PN dissector Guy Harris (Sep 26)
- Re: How to handle Ethernet frames with FCS, malformed packet in PN dissector Guy Harris (Sep 26)
- Re: How to handle Ethernet frames with FCS, malformed packet in PN dissector Stephen Fisher (Sep 26)
- Re: How to handle Ethernet frames with FCS, malformed packet in PN dissector Guy Harris (Sep 26)
- Re: How to handle Ethernet frames with FCS, malformed packet in PN dissector HPfrommer (Sep 27)
- Re: How to handle Ethernet frames with FCS, malformed packet in PN dissector Guy Harris (Sep 26)
- Re: How to handle Ethernet frames with FCS, malformed packet in PN dissector Guy Harris (Sep 26)