Re: Static analysis and FT_STRING encodings

[Jeff Morriss <jeff.morriss.ws () gmail com>]

Evan Huus wrote:
> On Thu, Apr 12, 2012 at 2:33 PM, Guy Harris <guy () alum mit edu 
> <mailto:guy () alum mit edu>> wrote:
[...]
>     ASCII has no byte-order issues, and the convention is that ENC_NA is
>     used to explicitly indicate that the byte order is not applicable.
>
>  
> But, as above, we already get that from the fact that it's ASCII in the 
> first place. If the agreed style is to be explicit in these cases, 
> that's fine, but then that should be made clearer in the comments.
>
> (As an aside, I'm assuming based on this that the few places which do 
> 'ENC_ASCII | ENC_BIG_ENDIAN' or 'ENC_ASCII | ENC_LITTLE_ENDIAN' are 
> actually wrong?)

Sounds wrong to me given this discussion; I removed all those places in 
r42297.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe