Wireshark mailing list archives

Re: [Wireshark-bugs] [Bug 3884] Assertion caused by fuzz test file


From: Gerald Combs <gerald () wireshark org>
Date: Fri, 10 Aug 2012 15:55:58 -0700

On 8/10/12 3:23 PM, bugzilla-daemon () wireshark org wrote:
@@ -166,6 +166,10 @@ expert_set_info_vformat(packet_info *pinfo, proto_item
*pi,.
+       if (pinfo == NULL && pi->tree_data)
+               pinfo = PTREE_DATA(pi)->pinfo;

Gerald, does it work when dissecting without tree?
I'm afraid it will crash with NULL dereference (pi == NULL).

It worked in my tests here but it looks like it would be an easy
condition to trigger. I added a check in r44437
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: