Wireshark mailing list archives

Re: ep_ memory is not garbage collected


From: Evan Huus <eapache () gmail com>
Date: Wed, 15 Aug 2012 10:22:13 -0400

On Wed, Aug 15, 2012 at 9:53 AM, Jakub Zawadzki
<darkjames-ws () darkjames pl> wrote:
From commit r42254 (reference counting of edt)
we have problem with ep_ memory not being returned to pool after dissecting packet.
Wireshark after initial opening file, always keep edt for currently selected packet,
so edt_refs is always > 0.

You can reproduce it by loading some bigger files, and several times open expert
or conversation window.

After r43188 (not part of wireshark-1.8) affected is also filtering (if at least one packet
match filter), or selecting other packets.

I'm not sure I follow. Are we calling epan_dissect_run() for each
packet selected without calling
epan_dissect_cleanup()/epan_dissect_init() in between? I understand
that to be a bug in the caller, not a bug in ep_'s memory manager, or
did r42254 change the behaviour of the API in an unexpected way?

Evan
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: