Wireshark mailing list archives
Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c
From: Evan Huus <eapache () gmail com>
Date: Sat, 01 Dec 2012 22:54:00 -0500
On Sat 01 Dec 2012 10:47:47 PM EST, Jeff Morriss wrote:
On 12/01/2012 10:23 PM, Evan Huus wrote:This sounds like something wmem could solve - if there is an intermediate scope between ep and se in duration then it should be possible to create another wmem scope for use here.Yeah, I thought so too but I took the quick way out (to shut the buildbot up).Is the needed scope for these addresses well defined?I'm not entirely sure, but it is (apparently) at least the old ep_ scope (in that the memory needs to be around at least until we *start* dissecting the next packet). At least one of the dissectors I looked at used (non-static!) local variables to hold their AT_STRINGZ. :-(
Ouch.I'm not sure either, but I think the addresses might need to stick around a little longer than that - maybe the length of the current dissection (ie until the file is loaded or the filter has finished running etc). That strikes me as a nice middle-ground between ep and se, although it may be unnecessarily long for this particular case.
Where exactly were the addresses being used that was after the ep memory was freed?
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Evan Huus (Dec 01)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Jeff Morriss (Dec 01)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Evan Huus (Dec 01)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Jakub Zawadzki (Dec 02)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Evan Huus (Dec 02)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Jeff Morriss (Dec 02)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Jakub Zawadzki (Dec 02)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Evan Huus (Dec 02)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Evan Huus (Dec 02)
- Re: [Wireshark-commits] rev 46320: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bthci_acl.c Jeff Morriss (Dec 01)