Wireshark mailing list archives
Re: [Wireshark-commits] rev 41216: /trunk/ /trunk/epan/dissectors/: packet-sctp.c /trunk/epan/: epan.c frame_data.c frame_data.h libwireshark.def packet.c packet.h packet_info.h reassemble.c /trunk/ui/gtk/: capture_file_dlg.c ...
From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Wed, 29 Feb 2012 12:36:47 -0500
morriss () wireshark org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=41216 User: morriss Date: 2012/02/27 07:19 PM Log: Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - make Save-As/Displayed/All-Packets save not only the displayed packets but also any other packets needed (e.g., for reassembly) to fully dissect the displayed packets.This works only for the "All packets" case; choosing only the Selected packet,the Marked packets, or a range of packets would require actually storing which packets depend on which (too much memory) or going through the packet list many times (too slow). Also, this behavior is always the case: you can't save the displayed packets without their dependencies (I don't see why this would be desirable).So far this is done for SCTP and things using the reassembly routines (TCP hasbeen tested).The Win32 dialog was modified but hasn't been tested yet. One confusing aspect of the UI is that the Displayed count in the Save-Asdialog does not match the number of displayed packets. (I tried renaming the button "Displayed + Dependencies" but it looked too big.) The tooltip tries to explain this and the fact that this works only in the All-Packets case; suggestions for improvement are welcome.
I thought of another way to implement this UI: basically to show the count of Displayed packets followed by " (+N dependencies)" (if there are any dependencies): see attached for an example. Is this better?
Only problem is that when I try this on Windows the "Packet Range" box does not expand for the extra width so (using the sample sample capture) only "39 (+ 169" ends up being displayed. Anyone know why that might be and/or how to fix it?
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 41216: /trunk/ /trunk/epan/dissectors/: packet-sctp.c /trunk/epan/: epan.c frame_data.c frame_data.h libwireshark.def packet.c packet.h packet_info.h reassemble.c /trunk/ui/gtk/: capture_file_dlg.c ... Jeff Morriss (Feb 29)