Re: [Wireshark-commits] rev 43176: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On 06/09/2012 01:08 PM, cmaynard () wireshark org wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43176
>
> User: cmaynard
> Date: 2012/06/09 10:08 AM
>
> Log:
>   Do not use BASE_NONE for FT_UINT8 types.
>   Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7333 (I think).

The code in epan/proto.c seems to indicate that using BASE_NONE with 
FT_*INT* types should be OK when there the strings converter is supplied:

>                 case FT_UINT32:
>                 case FT_UINT64:
>                         if (hfinfo->strings == NULL) {
>                                 /*  Require integral types (other than frame number,
>                                  *  which is always displayed in decimal) to have a
>                                  *  number base */
>                                 if (hfinfo->display == BASE_NONE)
>                                         g_error("Field '%s' (%s) is an integral value (%s)"
>                                                 " without strings but is being displayed as BASE_NONE\n",
>                                                 hfinfo->name, hfinfo->abbrev,
>                                                 val_to_str(hfinfo->type, hf_types, "(Unknown: %d)"));
>                         }

Where was it crashing (er, excepting out)?  (There's no sample PCAP file 
in that bug.)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe