Re: Problems in capture_win_ifnames.c

[Bill Meier <wmeier () newsguy com>]

On 11/23/2012 8:16 AM, Gisle Vanem wrote:
> "Guy Harris" <guy () alum mit edu> wrote:
>
> > Checked in (with the checks and #defines moved up a little earlier).
>
> Thanks. Works fine now. But I'm curious about why this:
>
>   #if 0 /* XXX: including config.h causes compilation errors; TBD: why */
>   #include "config.h"
>
> is needed. "config.h" should be able to live up there. No?
>
> And since the capture_win_ifnames.c code needs WS2, this:
>   #include <windows.h>
>   #include <winsock2.h>
>
> should be:
>   #include <winsock2.h>
>   #include <windows.h>
>
> incase someone forgot to add _WIN32_LEAN_AND_MEAN
> (which includes <winsock.h> by default).
>
> --gv



See https://www.wireshark.org/lists/wireshark-dev/201211/msg00096.html


Your suggestion about defining NDIS_IF_MAX_STRING_SIZE and NETIO_STATUS
fixed the problem.

I'll commit an update removing the 'if 0' and re-ordering the winsock2.h 
include.

Thanks

Bill

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe