Re: [Wireshark-commits] rev 45191: /trunk/ /trunk/epan/dissectors/: packet-btsap.c /trunk/: CMakeLists.txt

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On Fri, Sep 28, 2012 at 7:33 PM, Joerg Mayer <jmayer () loplof de> wrote:
> On Fri, Sep 28, 2012 at 04:29:14PM +0200, Jeff Morriss wrote:
> > >  Get rid of HAVE_CONFIG_H for cmake. Fix one case where it was still used.
> > [...]
> > >   +0 -1      CMakeLists.txt    Modified
> >
> > I had been assuming that we needed to continue to define HAVE_CONFIG_H
> > for backwards compatibility (e.g., for custom dissectors).  I guess
> > any old dissector could/should just take it out though.  Anyway I had
> > (intentionally) not removed the define (so it's still there in nmake
> > and autofoo too).
>
> Well, that way we found a missing cleanup in the main source ;-)
> I'm all for removing it from the other build mothods as well, but
> I don't care either way.

Just for the record: HAVE_CONFIG_H was removed from the Windows and Qt
builds in r45231 and r45232.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe