Re: order of include files

[Evan Huus <eapache () gmail com>]

On Thu, Oct 4, 2012 at 4:43 PM, Martin Kaiser <lists () kaiser cx> wrote:
> Hi,
>
> should the order in which we include files make any difference?
>
> #include <epan/packet.h>
> #include <epan/expert.h>
> -> ok
>
> #include <epan/expert.h>
> #include <epan/packet.h>
> -> failure
>
> expert.h needs packet_info.h, which is included by packet.h
>
> Trivial fix is of course to include packet_info.h in experts.h.
> Are such issues worth fixing?

Yes, fix them. It saves people unaware of the dependency countless
headaches, and costs basically nothing if everything is properly
guarded with #ifdefs.

Evan
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe