Wireshark mailing list archives

Re: [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c


From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Mon, 8 Oct 2012 13:12:50 +0200

On Sun, Sep 30, 2012 at 06:32:26PM +0200, Jakub Zawadzki wrote:
If we want to have bug #6208 fixed in 1.x we need to revert r45189 + do:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6208#c9

I'm not sure if I have time for writting such patch, but If anyone write one,
I can review.

Attaching patch for testing, still I have one XXX, to quote:

+  if (cf->count < frames_count && framenum <= cf->count) {
+    /* XXX, what we should do when new frames were received during rescaning but user clicked abort?
+     *   - call packet_list_append() for all new frames?
+     *   - just warn user?
+     */
+  }

Attachment: rescan-and-new-frames.patch
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: