Re: [Wireshark-commits] rev 44969: /trunk-1.8/epan/dissectors/ /trunk-1.8/epan/dissectors/: packet-per.c

[Anders Broman <anders.broman () ericsson com>]

> IMO, this looks like an incompatible change inside a stable release and should be reverted.

Well obviously I don't agree with you as I committed it ;-)

In my opinion it may as well be changed now as later the supprise will be the same. It can also be considered a bug as 
per._const_int_len hardly is a good filter string.

Best regards
Anders

-----Original Message-----
From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Joerg Mayer
Sent: den 18 september 2012 15:19
To: wireshark-dev () wireshark org
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 44969: /trunk-1.8/epan/dissectors/ /trunk-1.8/epan/dissectors/: 
packet-per.c

On Tue, Sep 18, 2012 at 12:16:51PM +0000, etxrab () wireshark org wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44969
>
> User: etxrab
> Date: 2012/09/18 05:16 AM
>
> Log:
>  Copy over the following revissions:
...
>  
> ----------------------------------------------------------------------
> ----------  Revision 44181 - remove unnecessary underscores from 
> display filters
>  
> ----------------------------------------------------------------------
> ----------

IMO, this looks like an incompatible change inside a stable release and should be reverted.

> Directory: /trunk-1.8/epan/dissectors/
>   Changes    Path            Action
>   +61 -49    packet-per.c    Modified

Ciao
       Jörg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft 
instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe