Wireshark mailing list archives

Re: [Wireshark-commits] rev 44978: /trunk/epan/ /trunk/epan/: packet.c


From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Tue, 18 Sep 2012 21:43:38 +0200

On Tue, Sep 18, 2012 at 03:32:21PM -0400, Maynard, Chris wrote:
Hmm, isn't this making an assumption about the dissector table?

dissector_add_uint() is used for more than just udp/tcp ports. 
Couldn't there be perfectly valid cases of registering a value of 0 for other tables besides "udp.port", "tcp.port" 
and others like those?

Yes, and I've already revert it in r44980.

Cheers,
 Kuba.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: