Re: [Wireshark-commits] rev 45019: /trunk/ /trunk/tools/lemon/: CMakeLists.txt

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On 09/20/2012 09:24 PM, Evan Huus wrote:
> On Thu, Sep 20, 2012 at 5:02 PM, Jeff Morriss <jeff.morriss.ws () gmail com> wrote:
> > Joerg Mayer wrote:
> > > On Thu, Sep 20, 2012 at 02:55:22AM +0000, eapache () wireshark org wrote:
> > > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=45019
> > > >
> > > > User: eapache
> > > > Date: 2012/09/19 07:55 PM
> > > >
> > > > Log:
> > > >   Fix lemon build with cmake by defining _U_. I feel like there's a better
> > > >   way than all the horrid escaping I had to do, but I don't know what it
> > > > is.
> > > >
> > > > Directory: /trunk/tools/lemon/
> > > >    Changes    Path              Action
> > > >    +6 -0      CMakeLists.txt    Modified
> > >
> > >
> > > Well, you could include config.h again, which defined _U_ before it was
> > > removed.
> >
> >
> > Ah, so cmake was putting _U_ in config.h?  I remember wondering once a long
> > time ago why _U_ wasn't in config.h (in autofoo and nmake); any reason not
> > to (uniformly) put it there?
>
> Not that I know of. Feel free to revert 45019 if there is a better solution.

Done (changes reverted and _U_ moved into config.h in non-cmake builds) 
in r45034.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe