Re: RRC filters

[Lucio Di Giovannantonio <lucio.digiovannantonio () gmail com>]

Hi pascal, thank you for your resply, maybe "container" could be better?

Regards
Lucio

Il 25/09/2012 16:34, Pascal Quantin ha scritto:
> Hi Lucio,
>
> 2012/9/25 Lucio Di Giovannantonio <lucio.digiovannantonio () gmail com 
> <mailto:lucio.digiovannantonio () gmail com>>
>
>     Hello to everybody, I've found something strange in rrc filters
>     expression, in several cases the same filter abbreviation have
>     different type, this can be a problem and/or can cause a crash?
>
>     for example:
>
>     { &hf_rrc_criticalExtensions_117,
>           { "criticalExtensions", "rrc.criticalExtensions",
>             FT_UINT32, BASE_DEC,
>     VALS(rrc_T_criticalExtensions_117_vals), 0,
>             "T_criticalExtensions_117", HFILL }},
>
>     and
>
>     { &hf_rrc_criticalExtensions_118,
>           { "criticalExtensions", "rrc.criticalExtensions",
>             FT_NONE, BASE_NONE, NULL, 0,
>             "T_criticalExtensions_118", HFILL }},
>
>
> This is a side effect of the code auto generated from the ASN.1 
> description. I proposed a workaround in bug 2402 comment #14.
> With it, the filters become:
> { &hf_rrc_criticalExtensions_117,
>       { "criticalExtensions", "rrc.criticalExtensions",
>         FT_UINT32, BASE_DEC, VALS(rrc_T_criticalExtensions_117_vals), 0,
>         "T_criticalExtensions_117", HFILL }},
>
> and
>
> { &hf_rrc_criticalExtensions_118,
>       { "criticalExtensions", "rrc.criticalExtensions_label",
>         FT_NONE, BASE_NONE, NULL, 0,
>         "T_criticalExtensions_118", HFILL }},
>
> But I'm not really satisfied with the _label extension and could not 
> come up to a better wording, so did not commit it. Any comment / 
> suggestion is welcome :)
>
> Regards,
> Pascal.
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>               mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


--

----------------------------------------------------------------
Lucio Di Giovannantonio
Prisma Engineering S.r.l.
Via Petrocchi, 4
20127 Milano

Tel: +39 02 26113507

Email: luciodg () prisma-eng com

This e-mail (including any attachments) is private and confidential, and may be privileged.  It is for the exclusive 
use of the intended recipient(s).  If you have received this email in error, please inform the sender immediately and 
then delete this email.  Unless you have been given specific permission to do so, please do not distribute or copy this 
email or its contents.

Unless the text of this email specifically states that it is a contractual offer or acceptance, the sender does not 
intend to create a legal relationship and this email shall not constitute an offer or acceptance which could give rise 
to a contract. Any views expressed in this communication are those of the individual sender, except where the sender 
specifically states them to be the views of Prisma Engineering S.r.l.

----------------------------------------------------------------

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe