Re: [Wireshark-commits] rev 45175: /trunk/epan/ /trunk/epan/: prefs.c

[Gerald Combs <gerald () wireshark org>]

On 9/27/12 12:42 PM, Jakub Zawadzki wrote:
> On Thu, Sep 27, 2012 at 12:24:09PM -0700, Guy Harris wrote:
> > On Sep 27, 2012, at 12:11 PM, Jakub Zawadzki <darkjames-ws () darkjames pl> wrote:
> >
> > > To do it, we can use g_strcmp0:
> > >  http://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html#g-strcmp0
> >
> > "Since 2.16", so we should then change the configure script to check for GLib 2.16 or later.
>
> Good point, I think we should change configure script, cause we're already using it:
>
> $ grep -Ir 'g_strcmp0' ./
> ./ui/gtk/main_menubar.c:        if (g_strcmp0(tok, "-") == 0) {
> ./ui/gtk/main_menubar.c:        if (g_strcmp0(tok, "-") == 0) {
> ./ui/gtk/main_menubar.c:        if (g_strcmp0(tok, "-") != 0) {
> ./fileset.c:    return g_strcmp0(entry->fullname, path);
>
> First introduced in r39410, another one r43455

We're using it in trunk-1.8 too, even though we shouldn't (the minimum
version of GLib there is 2.14). I switched to strcmp in r45180.

Increasing the minimum version of GLib 2.16 in the trunk is fine with
me. It was released in March 2008.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe