Re: [Wireshark-commits] rev 51119: /trunk/ /trunk/epan/: addr_resolv.c addr_resolv.h /trunk/ui/gtk/: addr_resolution_dlg.c

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On 08/05/13 11:17, Anders Broman wrote:
> -----Original Message-----
> From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Jeff Morriss
> Sent: den 5 augusti 2013 17:14
> To: wireshark-dev () wireshark org
> Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 51119: /trunk/ /trunk/epan/: addr_resolv.c addr_resolv.h 
> /trunk/ui/gtk/: addr_resolution_dlg.c
>
> On 08/05/13 09:18, Jeff Morriss wrote:
> > On 08/02/13 14:22, Jeff Morriss wrote:
> > > On 08/02/13 11:05, etxrab () wireshark org wrote:
> > > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=511
> > > > 19
> > > >
> > > > User: etxrab
> > > > Date: 2013/08/02 08:05 AM
> > > >
> > > > Log:
> > > >    - Use a hashtable for eth lookup.
> > > >    Currently broken get_ether_addr().
> > > >    - Show hastable content in address dlg.(temp solution).
> > >
> > > This (or maybe another rev) is causing plenty of errors like:
> > >
> > > > (lt-wireshark:6958): GLib-CRITICAL **: g_hash_table_lookup:
> > > > assertion `hash_table != NULL' failed
> >
> > Michael fixed this in r51133.
> >
> > Oops, I spoke too soon.  There are still some in there.
>
> Perhaps the table(s) should be crated at initialize_ethers()?

I did that (and some more) in r51191.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe