Re: Compilation failure in gtk/stats_tree_stat.c

[Guy Harris <guy () alum mit edu>]

On Dec 2, 2013, at 2:55 AM, Joerg Mayer <jmayer () loplof de> wrote:

> [ 83%] Building C object ui/gtk/CMakeFiles/gtkui.dir/stats_tree_stat.c.o
> /home/jmayer/work/wireshark/svn/trunk/ui/gtk/stats_tree_stat.c: In function ‘save_as_dialog’:
> /home/jmayer/work/wireshark/svn/trunk/ui/gtk/stats_tree_stat.c:296:3: error: enum conversion when passing argument 2 
> of ‘stats_tree_format_as_str’ is invalid in C++ [-Werror=c++-compat]
>   str_tree=stats_tree_format_as_str(st,file_type,sort_column-N_RESERVED_COL,order==GTK_SORT_DESCENDING);
>   ^
> In file included from /home/jmayer/work/wireshark/svn/trunk/ui/gtk/stats_tree_stat.c:41:0:
> /home/jmayer/work/wireshark/svn/trunk/epan/stats_tree_priv.h:283:24: note: expected ‘st_format_type’ but argument is 
> of type ‘int’
> WS_DLL_PUBLIC GString* stats_tree_format_as_str(const stats_tree* st,
>                        ^
> cc1: all warnings being treated as errors
> make[2]: *** [ui/gtk/CMakeFiles/gtkui.dir/stats_tree_stat.c.o] Error 1

Cast added to squelch the warning.

A pointer to file_type is passed to file-save-dialog routines, so I'm not sure it can be made an enum variable.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe