Wireshark mailing list archives
Re: Windows version info
From: Pascal Quantin <pascal.quantin () gmail com>
Date: Sun, 8 Dec 2013 23:32:05 +0100
Hi Graham, Le 8 déc. 2013 à 22:56, Graham Bloice <graham.bloice () trihedral com> a écrit :
Compiling with VS2013, the GetVersionEx function is now reported as deprecated: E:\Wireshark\trunk\version_info.c(368): warning C4996: 'GetVersionExW': was declared deprecated [E:\Wireshark\2013build\wireshark.vcxproj] E:\Wireshark\trunk\version_info.c(853): warning C4996: 'GetVersionExW': was declared deprecated [E:\Wireshark\2013build\wireshark.vcxproj] E:\Wireshark\trunk\ui\win32\file_dlg_win32.c(451): warning C4996: 'Get VersionExW': was declared deprecated [E:\Wireshark\2013build\wireshark.vcxproj]
Normally with nmake builds we should have a flag removing this warning (see bug 9375 and revision 53059). Are you using cmake?
Should we switch over to using the Version Helpers API and\or VerifyVersionInfo (and remove a lot of cruft from version_info.c)? This has already been partially implemented in ui\win32\file_dlg.c as part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9297 Version Helpers API: http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972(v=vs.85).aspx
This is not what we need for version_info.c: this new API allows you to check a minimum OS requirement, not to get current OS version. See my comments in bugs 9297, 9298 and 9375 for more details. Regards, Pascal.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Windows version info Graham Bloice (Dec 08)
- Re: Windows version info Pascal Quantin (Dec 08)
- Re: Windows version info Graham Bloice (Dec 09)
- Re: Windows version info Pascal Quantin (Dec 09)
- Re: Windows version info Graham Bloice (Dec 09)
- Re: Windows version info Graham Bloice (Dec 09)
- Re: Windows version info Graham Bloice (Dec 09)
- Re: Windows version info Pascal Quantin (Dec 08)