Re: To display reserved fields or not display reserved fields, that is the question...

[Edwin Groothuis <Edwin.Groothuis () riverbed com>]

Hello,

Display it. You are writing a dissector which describes the data seen on the wire, not one which goes "You are not 
interested in this".

Also, if there is something on the screen which says "Reserved" or a number of bits which say "Not in use" and there is 
a value in it, then you know that there has been some update in the protocol and that you need to update your dissector.

Edwin

From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Kaul
Sent: Monday, 9 December 2013 02:54
To: Developer support list for Wireshark
Subject: [Wireshark-dev] To display reserved fields or not display reserved fields, that is the question...

Should I:

proto_tree_add_text(seg_param_tree, tvb, offset, 2, "reserved");
offset += 2;

or:
offset += 2; /* reserved */

What is better? (Regretully I'm working on SCSI, whose creators LOVED sprinkling reserved bytes everywhere!).


Do we have a standard? (perhaps worth having a global param for it?!).
Y.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe