Re: checkett.pl anyone?

[Dirk Jagdmann <doj () cubic org>]

> Anyone able to create a checkett.pl script to check for this?

Note that checkAPI.pl contains code to check etts, but it is currently 
disabled, because it generates lots of false positives. I've written a 
naive approach to also check for etts (see attachment), but using it 
with the dissector sources again produces a lot of false positives. Lots 
of dissectors register more than one ett array. They often assign ett 
values around into local variables, which will again report false positives.

Since the proto_item_add_subtree() function has a DISSECTOR_ASSERT() to 
check for a valid ett value, that's probably a better approach. It is 
not a static code analysis, but if our users report on issues, it's easy 
to fix them.

--
---> Dirk Jagdmann
----> http://cubic.org/~doj
-----> http://llg.cubic.org

Attachment: checkett.pl
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe