Re: [Wireshark-commits] rev 47832: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-beep.c

["Maynard, Chris" <Christopher.Maynard () GTECH COM>]

Coverity CID 986569 reports an unused pointer value at line 665:

      ti = proto_tree_add_item(hdr, hf_beep_cmd, tvb, offset, 3, ENC_NA|ENC_ASCII);

... but looking at http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/packet-beep.c?r1=47389&r2=47832, I am 
confused by the change made here because hf_beep_cmd is already added to the tree at line 616.  What happened to 
hf_beep_end?

I don't know, this looks wrong to me.
- Chris

-----Original Message-----
From: wireshark-commits-bounces () wireshark org [mailto:wireshark-commits-bounces () wireshark org] On Behalf Of mmann 
() wireshark org
Sent: Friday, February 22, 2013 10:48 PM
To: wireshark-commits () wireshark org
Subject: [Wireshark-commits] rev 47832: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-beep.c

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47832

User: mmann
Date: 2013/02/22 07:48 PM

Log:
 Convert proto_tree_add_text to proto_tree_add_item and expert_info.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +101 -185  packet-beep.c    Modified

CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended 
recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, 
distribution or copying of this communication is strictly prohibited. If you have received this communication in error, 
please immediately delete it from your system and notify the sender by replying to this email.  Thank you.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe