Wireshark mailing list archives

Re: [Wireshark-commits] rev 47059: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c

From: Bill Meier <wmeier () newsguy com>
Date: Mon, 14 Jan 2013 10:11:30 -0500

On 1/14/2013 9:11 AM, Jeff Morriss wrote:

Martin Mathieson wrote:


That appears to be an artifact of the fact that those diff's are
(intentionally) not showing white space changes.  I have the same
problem (indentation looking wrong) when I do "svn diff -x -w" to show
me my (real) changes.


Yep...

The rule I should follow (which I pretty much did in this case buthaven't on a number of occasions) is to keep substantive changes in aseparate commit from whitespace fixups, etc.


Bill

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread:

Re: [Wireshark-commits] rev 47059: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Martin Mathieson (Jan 14)
- Re: [Wireshark-commits] rev 47059: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Jeff Morriss (Jan 14)
  - Re: [Wireshark-commits] rev 47059: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Bill Meier (Jan 14)