Wireshark mailing list archives

Re: [Wireshark-commits] rev 50836: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-mongo.c


From: Alexis La Goutte <alexis.lagoutte () gmail com>
Date: Tue, 23 Jul 2013 17:08:43 +0200

On Tue, Jul 23, 2013 at 5:03 PM, Maynard, Chris <
Christopher.Maynard () gtech com> wrote:

From doc/README.dissector, it seems like passing -1 for the length should
work:


It works in 1.8.x...
I am trying to make a git bisect to find the source of this problem...

Regards,


    FT_STRINGZ  A NULL-terminated string of characters.
                The string length is normally the length
                given in the proto_tree_add_item() call.
                However if the length given in the call
                is -1, then the length used is that
                returned by calling tvb_strsize().

If not, does the documentation need updating?
- Chris

-----Original Message-----
From: wireshark-commits-bounces () wireshark org [mailto:
wireshark-commits-bounces () wireshark org] On Behalf Of jmayer () wireshark org
Sent: Tuesday, July 23, 2013 9:39 AM
To: wireshark-commits () wireshark org
Subject: [Wireshark-commits] rev 50836: /trunk/epan/dissectors/
/trunk/epan/dissectors/: packet-mongo.c

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50836

User: jmayer
Date: 2013/07/23 06:38 AM

Log:
 Fix for Bug 8960 - All mongodb query show as [Malformed Packet: MONGO]

 proto_tree_add_item doesn't link to be called with FT_STRINGZ and length
-1.

Directory: /trunk/epan/dissectors/
  Changes    Path              Action
  +1 -1      packet-mongo.c    Modified

--

CONFIDENTIALITY NOTICE: The information contained in this email message is
intended only for use of the intended recipient. If the reader of this
message is not the intended recipient, you are hereby notified that any
dissemination, distribution or copying of this communication is strictly
prohibited. If you have received this communication in error, please
immediately delete it from your system and notify the sender by replying to
this email.  Thank you.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org
?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: