Wireshark mailing list archives

Re: [Wireshark-commits] rev 50935: /trunk/epan/ /trunk/epan/dissectors/: packet-collectd.c /trunk/epan/: proto.c proto.h value_string.c value_string.h


From: Evan Huus <eapache () gmail com>
Date: Sun, 28 Jul 2013 15:56:44 -0400

On Sun, Jul 28, 2013 at 3:36 PM, Stig Bjørlykke <stig () bjorlykke org> wrote:
On Fri, Jul 26, 2013 at 11:51 PM,  <eapache () wireshark org> wrote:
 Add 64-bit value strings and the appropriate tooling (including yet another
 overloaded use of the DISPLAY field).

While looking at adding 64-bit value strings support for Lua I found
that the tree entry contains double name entry:

  "Value: Something (Value: 42)"

The correct entry should be (like it is for 32-bit):

  "Value: Something (42)"


The bug is in fill_label_number64(), where the format should be
without the leading "%s: " and hfinfo->name.

Thanks, fixed in r50982.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: