Re: [Wireshark-commits] rev 50896: / /trunk/doc/: README.qt /trunk/epan/: prefs-int.h prefs.c prefs.h uat-int.h uat.h /trunk/ui/qt/: CMakeLists.txt Makefile.common QtShark.pro elided_label.cpp elided_label.h /trunk/: ...

[Joerg Mayer <jmayer () loplof de>]

On Tue, Jul 30, 2013 at 11:41:09AM -0700, Gerald Combs wrote:
> BTW, it looks like you can pull Makefile-style definitions into CMake.
> This would make maintenance easier everywhere, not just in ui/qt:
>
> https://github.com/berenm/xoreos/blob/a187e94eca041c7c53c76e943483fcaa612cbf4a/cmake/CMakeAM.cmake

It looks like it does not really what I want - it seems to read configure.ac
and Makefile.am files and create the targets from that. Doing that would be
"not helpful (tm)", as we would loose all the features that prompted me to
start the cmake stuff in the first place.

Reading Makefile.common is an entirely different thing and I started to
write an importer for that when I did the asn1/ stuff. It didn't really
work though. When I looked at the like above I got the idea that replacing
the macros by functions might solve that problem.
I've attached my original implementation. I won't be able to work on that
for the next 10 days or so due to paid work.

Ciao
   Jörg

-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.

Attachment: cmake-makefilecommon.patch
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe