Re: [Wireshark-commits] rev 50141: / /trunk/echld/: CMakeLists.txt echld_parent.c /trunk/: Makefile.am configure.ac echld_test.c

[Joerg Mayer <jmayer () loplof de>]

Some notes about echld:

On Tue, Jun 25, 2013 at 05:43:53PM +0000, lego () wireshark org wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50141
>
> User: lego
> Date: 2013/06/25 10:43 AM
>
> Log:
>  This should get cmake to ignore echld...
>
> Directory: /trunk/echld/
>   Changes    Path              Action
>   +80 -0     CMakeLists.txt    Added
>   +47 -32    echld_parent.c    Modified
>
> Directory: /trunk/
>   Changes    Path            Action
>   +29 -5     Makefile.am     Modified
>   +28 -0     configure.ac    Modified
>   +2 -1      echld_test.c    Modified

Is there any reason for creating a separate echld library? It should be fine
as part of libepan.
Execept for echld.h I also see no reason to prefix the filenames with
echld_, as these files are now inside their own directroy already named echld.

Ciao
      Jörg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe