Re: [Wireshark-commits] rev 50197: /trunk/epan/ /trunk/epan/: proto.c

[Jakub Zawadzki <darkjames-ws () darkjames pl>]

On Thu, Jun 27, 2013 at 03:28:00PM -0400, Evan Huus wrote:
> On Thu, Jun 27, 2013 at 3:17 PM,  <darkjames () wireshark org> wrote:
> >  XXX: to be honest I don't get it why if dev picked up BASE_DEC_HEX and has value string we're truncating it to 
> > BASE_DEC...
>
> Nesting parentheses? If I recall correctly, BASE_DEC_HEX displays as
> dec_val (hex_val), and value strings display as string (value). So if
> you use the two together you get string (dec_val (hex_val)) which is a
> bit odd. 

It looks ok for me :)

> This is just a guess though, I didn't write that code.

Ok, but some dissectors are actually using it:

Field 'ActivationFlags' (isystemactivator.properties.instninfo.actflags) is dual display (hex/dec) but has strings
Field 'MDEP ID' (btsdp.hdp.supported_features.mdep_id) is dual display (hex/dec) but has strings
Field 'L2CAP PSM' (btsdp.protocol.psm) is dual display (hex/dec) but has strings
Field 'Country Code' (btsdp.service.hid.country_code) is dual display (hex/dec) but has strings
Field 'Type' (db-lsp.type) is dual display (hex/dec) but has strings
Field 'OP Value' (db-lsp.op) is dual display (hex/dec) but has strings
...
Field 'time' (x11.xv.GrabPort.time) is dual display (hex/dec) but has strings
Field 'time' (x11.xv.UngrabPort.time) is dual display (hex/dec) but has strings

Total: 249
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe