Re: [Wireshark-commits] rev 47987: /trunk/tools/lemon/ /trunk/tools/lemon/: lemon.c

[Anders Broman <a.broman () bredband net>]

Evan Huus skrev 2013-03-01 22:03:
> On Fri, Mar 1, 2013 at 3:56 PM, Anders Broman <a.broman () bredband net> wrote:
> > Evan Huus skrev 2013-03-01 21:38:
> >
> > > Not entirely sure this sort of thing is necessary - lemon is not our
> > > tool, so even if Wireshark switches to C++ there's no immediately
> > > obvious reason to start compiling other people's code (which we happen
> > > to use) in C++ as well.
> > >
> > > Evan
> > It's nice to get rid of the warnings regardless, isn't it?
> For tools with an upstream maintainer independent of Wireshark (as is
> the case with lemon - it is maintained by sqlite for some reason) I
> think it is generally better to avoid carrying a delta with upstream
> unless absolutely necessary. It may be worth submitting your changes
> to sqlite, then pulling a new version of lemon once they merge the
> changes.
This is actually copying changes from upstream to Wireshark 
unfortunately the two has diverged
and strict back porting isn't possible(?)

> > > On Fri, Mar 1, 2013 at 3:32 PM,  <etxrab () wireshark org> wrote:
> > > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47987
> > > >
> > > > User: etxrab
> > > > Date: 2013/03/01 12:32 PM
> > > >
> > > > Log:
> > > >    try to remove C++ incompatibilities from lemon
> > > >
> > > > Directory: /trunk/tools/lemon/
> > > >     Changes    Path          Action
> > > >     +95 -89    lemon.c       Modified
> > > >
> > > >
> > > > ___________________________________________________________________________
> > > > Sent via:    Wireshark-commits mailing list
> > > > <wireshark-commits () wireshark org>
> > > > Archives:    http://www.wireshark.org/lists/wireshark-commits
> > > > Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
> > > >
> > > > mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
> > >
> > > ___________________________________________________________________________
> > > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > > Archives:    http://www.wireshark.org/lists/wireshark-dev
> > > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> > >
> > > mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    http://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>               mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe