Re: [Wireshark-commits] rev 48227: /trunk/epan/ /trunk/epan/dissectors/: packet-tcp.c /trunk/epan/: proto.c slab.h /trunk/epan/ftypes/: ftypes.c

[Evan Huus <eapache () gmail com>]

Of possible interest: this change exposed a fairly significant memory
leak in the TCP dissector.

==31545== 233,960 (172,560 direct, 61,400 indirect) bytes in 4,314
blocks are definitely lost in loss record 31,667 of 31,670
==31545==    at 0x4C2CD7B: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31545==    by 0x9290CD0: g_malloc (gmem.c:159)
==31545==    by 0x92A5EE2: g_slice_alloc (gslice.c:1003)
==31545==    by 0x69D7B9B: dissect_tcp (packet-tcp.c:1121)
==31545==    by 0x637EF27: call_dissector_through_handle (packet.c:458)
==31545==    by 0x637F74C: call_dissector_work (packet.c:549)
==31545==    by 0x637FF9F: dissector_try_uint_new (packet.c:966)
==31545==    by 0x637FFF6: dissector_try_uint (packet.c:992)
==31545==    by 0x66FF6BF: dissect_ip (packet-ip.c:2413)
==31545==    by 0x637EF27: call_dissector_through_handle (packet.c:458)
==31545==    by 0x637F74C: call_dissector_work (packet.c:549)
==31545==    by 0x637FF9F: dissector_try_uint_new (packet.c:966)

Don't have time to look for a while, so if someone who knows the TCP
dissector wants to fix it, be my guest :)

This is with the capture from
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8456

On Sun, Mar 10, 2013 at 10:52 AM,  <eapache () wireshark org> wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=48227
>
> User: eapache
> Date: 2013/03/10 07:52 AM
>
> Log:
>  Remove slab.h and replace its last remaining usage with glib slices.
>
>  Take the opportunity to deduplicate some code that was common to both an
>  if block and its else block.
>
> Directory: /trunk/epan/dissectors/
>   Changes    Path            Action
>   +3 -16     packet-tcp.c    Modified
>
> Directory: /trunk/epan/
>   Changes    Path          Action
>   +0 -1      proto.c       Modified
>   +0 -75     slab.h        Removed
>
> Directory: /trunk/epan/ftypes/
>   Changes    Path          Action
>   +0 -1      ftypes.c      Modified
>
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe