Wireshark mailing list archives
Drop sql-oracle dissector?
From: Evan Huus <eapache () gmail com>
Date: Sat, 16 Mar 2013 22:17:04 -0400
packet-sqloracle.c is currently not being built (not listed in either Makefile.common or CMakeLists.txt). It was mentioned in bug #8449 because Moshe noticed that it had a really egregious buffer overflow condition while doing random code review. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8449 Having taken a look at the dissector, it is an absolute mess. Tons of obvious bugs, bad practices, etc. There is no way it would be accepted as a patch, were it filed new today (and nobody seems to know who wrote it anyways). So, since nobody has complained about the fact that it's disabled, and it looks like nearly as much work to rewrite as it is to fix, I'm happy just removing it completely. Thoughts? ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Drop sql-oracle dissector? Evan Huus (Mar 16)
- Re: Drop sql-oracle dissector? Guy Harris (Mar 16)
- Re: Drop sql-oracle dissector? Evan Huus (Mar 17)
- Re: Drop sql-oracle dissector? Guy Harris (Mar 16)