Re: [Wireshark-commits] rev 53435: / /trunk/ui/gtk/: main.c /trunk/ui/qt/: main.cpp /trunk/ui/: CMakeLists.txt Makefile.common persfilepath_opt.c persfilepath_opt.h /trunk/wsutil/: filesystem.c filesystem.h

[Guy Harris <guy () alum mit edu>]

On Nov 20, 2013, at 4:04 AM, Anders Broman <anders.broman () ericsson com> wrote:

> In persfilepath_opt.h
> WS_DLL_PUBLIC gboolean persfilepath_opt(int opt, const char *optstr); does not seem to work on windows where as
> extern gboolean persfilepath_opt(int opt, const char *optstr); does...

Yes - libui isn't a dynamic library, so the WS_DLL_PUBLIC isn't necessary and, as noted, doesn't appear to work.

I've checked in a fix.

> in main.c 
> 2155  int                  status;
> Should be inside #ifdef HAVE_LIBPCAP I think.

Yes.  I've checked in a fix.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe