Re: [Wireshark-commits] rev 53676: / /trunk/codecs/G722/: G722decode.c G722decode.h /trunk/codecs/G726/: G726decode.c G726decode.h /trunk/codecs/SBC/: sbc.c sbc.h /trunk/codecs/: CMakeLists.txt Makefile.am Makefile.nmake

[Joerg Mayer <jmayer () loplof de>]

On Sat, Nov 30, 2013 at 03:42:14PM +0000, mmann () wireshark org wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=53676
>
> User: mmann
> Date: 2013/11/30 03:42 PM
>
> Log:
>  Add G.722, G.726 and SBC codecs.  G.722 and G.726 are from bug 5619 
> (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5619) and SBC is from bug 7893 
> (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893).
>  
>  Codecs are added, but (intentionally) not hooked to the RTP player as a "more generic architecture" is desired.  
> There are some discussions in bug 7893 on how to do this.  One thing to add would be how to handle codecs that may 
> not be supported on all platforms.  Should the codec not be "registered" at all (with a #define over the whole 
> module) or should it's register functions be stubbed (with a #define in each function that requires a non-supported 
> library)

The plugins should only be built in case the necessary libraries are available
(just like we do not build wireshark in case we do not find gtk2 or gtk3).

Ciao
     Jörg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe