Wireshark mailing list archives
Re: Adding a new dissector - beginners guide
From: Graham Bloice <graham.bloice () trihedral com>
Date: Thu, 21 Aug 2014 15:25:27 +0100
On 21 August 2014 15:04, Thomas Wiens <th.wiens () gmx de> wrote:
On 21 August 2014 15:14, Graham Bloice wrote:Have a look at the Wiki page on submitting patches: http://wiki.wireshark.org/Development/SubmittingPatches which advisesusingthe Gerrit helper git-reviewOh man, that's a hard task to upload 4 files. Is this review addon absolute necessary? Can't get this under windows with git/cygwin and all the other stuff running. Is a change the same when I want to add new files?
git-review isn't compulsory but it does make your life easier. I use it with Windows, see the GitForWindows page on the wiki: http://wiki.wireshark.org/Development/SubmittingPatches/GitForWindows To push the change manually see the Gerrit docs: https://code.wireshark.org/review/Documentation/user-upload.html Don't confuse git and Gerrit. Use git to add files to your staging area and then commit them to your repository, and then push the commit to Gerrit, where the Gerrit review process takes over. -- Graham Bloice
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Michal Orynicz (Aug 21)
- Re: Adding a new dissector - beginners guide Michal Orynicz (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Graham Bloice (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Graham Bloice (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Jeff Morriss (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Jeff Morriss (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Martin Kaiser (Aug 21)
- Re: Adding a new dissector - beginners guide Jeff Morriss (Aug 21)
- Re: Adding a new dissector - beginners guide Christopher Maynard (Aug 21)
- Re: Adding a new dissector - beginners guide Graham Bloice (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 22)
- Re: Adding a new dissector - beginners guide Michal Orynicz (Aug 21)