Re: [Wireshark-commits] master b736896: Handle floorl() the same way we handle other not-on-all-platforms functions.

[Stephen Fisher <sfisher () SDF ORG>]

Thanks for correcting this.  I see now that there are other functions 
defined the way you re-defined floorl().  The example I randomly picked 
to follow was wsutil/tempfile.[ch], which is done with just 
AC_CHECK_FUNCS() and #ifndef HAVE_MKSTEMP.  Does that need to be 
corrected too then?

On Sat, Dec 20, 2014 at 02:54:08AM +0000, Wireshark code review wrote:
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b73689649059060c5876a8ae281a2ded58a1b8fc
> Submitter: Guy Harris (guy () alum mit edu)
> Changed: branch: master
> Repository: wireshark
>
> Commits:
>
> b736896 by Guy Harris (guy () alum mit edu):
>
>     Handle floorl() the same way we handle other not-on-all-platforms functions.
>     
>     Use AC_CHECK_FUNC() for it, define FLOORL_LO to floorl.lo if we *don't*
>     have it, add FLOORL_LO to the list of items conditionally built in
>     libwsutil, and include "wsutil/floor.h" only if HAVE_FLOORL is *not*
>     defined, as that means it's *not* supplied by the platform and thus
>     *not* declared in <math.h>.
>     
>     Also, use the standard export stuff in wsutil/floor.h.
>     
>     Change-Id: Ic24aa69f65f2d15450d8b84b0c2b0c58f38edebe
>     Reviewed-on: https://code.wireshark.org/review/5901
>     Reviewed-by: Guy Harris <guy () alum mit edu>
>     
>
> Actions performed:
>
>     from  201a7e7   Change more variables from si_code to mtp3_si_code to avoid conflicts with a #define in a NetBSD 
> header file.
>     adds  b736896   Handle floorl() the same way we handle other not-on-all-platforms functions.
>
>
> Summary of changes:
>  configure.ac       |    9 ++++++++-
>  ui/time_shift.c    |    4 +++-
>  wsutil/Makefile.am |    1 +
>  wsutil/floor.h     |   14 ++++++++++----
>  4 files changed, 22 insertions(+), 6 deletions(-)
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe