Re: [Wireshark-commits] master 3147087: Fix ranlib "has no symbols" errors in the codecs directory.

[Alexis La Goutte <alexis.lagoutte () gmail com>]

On Wed, Dec 10, 2014 at 12:28 AM, Guy Harris <guy () alum mit edu> wrote:
> On Dec 9, 2014, at 1:25 PM, Wireshark code review <code-review-do-not-reply () wireshark org> wrote:
>
> > URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3147087de323c0294b51006f97b641fc408f1b06
> > Submitter: Gerald Combs (gerald () wireshark org)
> > Changed: branch: master
> > Repository: wireshark
> >
> > Commits:
> >
> > 3147087 by Gerald Combs (gerald () wireshark org):
> >
> >    Fix ranlib "has no symbols" errors in the codecs directory.
> >
> >    Don't build the G.722 or G.726 codecs for now. Each are wrapped in
> >    "#ifdef HAVE_SPANDSP", which we don't define.
>
> Should we be checking for that library:
>
>         http://www.soft-switch.org
>
> as per, for example:
>
>         https://www.wireshark.org/lists/wireshark-dev/201412/msg00013.html
>
> and
>
>         https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5619
>
> or is spandsp not yet mature or cross-platform (where "platform" includes "CPU" - and "generation of the instruction 
> set of that CPU") enough?
>
> They also say:
>
>         http://www.soft-switch.org/installing-spandsp.html
>
> "A number of Linux and other software distributions include SpanDSP, but they usually supply older versions of the 
> library, which lack a lot of the features of the current version."
>
> Even if we don't want to use it by default if present, should we have --with-spandsp, defaulting to "no", so that 
> people don't have to do quite as much work to use it if they choose to build a custom version of Wireshark?
Good for me
(There is already some code for CMakeList ?)
And there is already some stuff only for Linux only like SBC (Codec
for Bluetooth A2DP stream playing)

Gerald
About GXXX Codec, the Qt port will be enhance this support (with
QtMultimediaWidgets) ? (or need always some external lib)

Regards,
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe