Re: tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

[darkjames-ws () darkjames pl]

Hi,

On Fri, Jul 11, 2014 at 11:12:37PM +0200, B??lint R??czey wrote:
> Please provide the input data for letting others reproduce the results
> or perform the performance tests on pcap files already available to
> the public.

I have only fake one:
http://www.wireshark.org/~darkjames/tvb-opt-allocator/udp-test/udp-tvb-benchmark.pcap.xz 
(eth:ethertype:vlan:ethertype:ip:udp:sip])

This generally always shows up.
If you have small amount of frames just substract time spend in epan_init()
(as it doesn't matter of number of capture files).

Profiled target:  /tmp/wireshark/.libs/tshark -nr /tmp/udp-tvb-benchmark.pcap (...)

===   git revision: 450f4916522b0099364e8978405c048362c9e745 ===

3,241,026,732  PROGRAM TOTALS
  545,660,479  >   ???:epan_init (1x) [/tmp/wireshark/epan/.libs/libwireshark.so.0.0.0]
 ----
   65,641,038  *  ???:tvb_new [/tmp/wireshark/epan/.libs/libwireshark.so.0.0.0]
   78,702,144  *  ???:tvb_free_chain [/tmp/wireshark/epan/.libs/libwireshark.so.0.0.0]
 ----
  tvb allocation: 144.3 / 3241.0 = 4.4% of total
  tvb allocation: 144.3 / 2695.3 = 5.3% of total - epan_init()

=== git revision: 450f4916522b0099364e8978405c048362c9e745 + ver2 of patch ===

3,174,032,847  PROGRAM TOTALS
  544,803,794  *  ???:epan_init [/tmp/wireshark/epan/.libs/libwireshark.so.0.0.0]
 ----
   43,514,953  *  ???:tvb_new [/tmp/wireshark/epan/.libs/libwireshark.so.0.0.0]
   27,263,712  *  ???:tvb_free_chain [/tmp/wireshark/epan/.libs/libwireshark.so.0.0.0]
 ----
  tvb allocation: 70.7 / 3174.0 = 2.2% of total
  tvb allocation: 70.7 / 2629.2 = 2.7% of total (without initialization)

======================================================================================

Cheers,
Jakub.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe