Wireshark mailing list archives

Should checkapi check for "bad" includes?


From: Joerg Mayer <jmayer () loplof de>
Date: Sat, 21 Jun 2014 15:41:14 +0200

Hello,

Guy's recent changes to packet-corosync-totemsrp.c make me look at some
includes that should not be necessary in dissectors. Is there a valid
(design) use for the following includes in the dissectors/ subtree?

sys/socket.h
netinet/in.h
winsock2.h

Should other includes be added to this list?

Thanks
  Jörg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: