Re: Can Gerrit update a change when it's cherry-picked to another branch?

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On 09/04/14 14:37, Pascal Quantin wrote:
> Le 4 sept. 2014 20:32, "Jeff Morriss" <jeff.morriss.ws () gmail com
> <mailto:jeff.morriss.ws () gmail com>> a écrit :
>  >
>  > On 09/04/14 14:10, Alexis La Goutte wrote:
>  >>
>  >> On Thu, Sep 4, 2014 at 8:05 PM, Jeff Morriss
> <jeff.morriss.ws () gmail com <mailto:jeff.morriss.ws () gmail com>> wrote:
>  >>>
>  >>> On 09/04/14 13:43, Alexis La Goutte wrote:
>  >>>>
>  >>>>
>  >>>> Hi Jeff,
>  >>>>
>  >>>> No, it is not possible... (never modified a commit push on master...)
>  >>>
>  >>>
>  >>>
>  >>> Note that I don't care about modifying the commit on master just
> the change
>  >>> in Gerrit.  I can certainly add comments to a change after it's
> been merged.
>  >>
>  >>
>  >> There is already :
>  >>
>  >> Patch Set 2: Cherry Picked
>  >>
>  >> This patchset was cherry picked to branch master-1.12 as commit
>  >> fd091c4517101d0148b4308bb53a99724147ab94
>  >>
>  >> https://code.wireshark.org/review/#/c/3959/
>  >>
>  >> (if you use cherry-pick button on Gerrit)
>  >
>  >
>  > Hmmm, odd, yeah, I remember seeing that before too.  But it's not
> there for this change:
>  >
>  > https://code.wireshark.org/review/#/c/2646/
>  >
>  > which I recently cherry-picked to master-1.12 (via the Gerrit web
> interface):
>  >
>  > https://code.wireshark.org/review/#/c/3989/
>  >
>  > OK, well, I guess I'll chalk that up to Gerrit having a bad day.
>  >
> It is present:
>
> Patch Set 2: Cherry Picked
>
> This patchset was cherry picked to branch master-1.12 as commit
> 00b96dd08671bb8ecef63515c4f3f0921b11c25a

Oh, haha, funny (in that "not so funny" way).  I guess Firefox doesn't 
like me today.  As often as I reload the link for change 2646, I still 
don't see what you quoted.  But if I load it on a different computer I 
do see it.  <sigh>  Sorry for the noise!

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe