Re: Windows automated builds migrated to CMake

[Gerald Combs <gerald () wireshark org>]

It's defined in cmake/modules/UseCheckAPI.cmake which is included by the
top-level CMakeLists.txt. It's run by the Visual Studio Code Analysis builder.

On 4/16/15 7:12 AM, Anders Broman wrote:
> Hi,
> The checkAPI target is missing from the cmake build isn't it?
> Regards
> Anders
>
> Pascal Quantin skrev den 2015-04-16 15:09:
> > 2015-04-16 14:55 GMT+02:00 Graham Bloice <graham.bloice () trihedral com
> > <mailto:graham.bloice () trihedral com>>:
> >
> >
> >
> >     On 16 April 2015 at 11:49, Pascal Quantin <pascal.quantin () gmail com
> >     <mailto:pascal.quantin () gmail com>> wrote:
> >
> >
> >
> >         2015-04-16 5:06 GMT+02:00 Gerald Combs <gerald () wireshark org
> >         <mailto:gerald () wireshark org>>:
> >
> >             We reached a bit of a milestone today. The packages created
> >             by the
> >             32-bit and 64-bit Windows builders at
> >             https://buildbot.wireshark.org/trunk/waterfall are now
> >             produced using
> >             CMake and MSBuild.
> >
> >             Thanks to everyone for helping to get the Windows CMake
> >             environment up
> >             and running!
> >
> >
> >         Hi Gerald,
> >
> >         one thing I noticed is that the Wireshark 1.99.6-243 32 bits
> >         coming from the buildbot (and thus CMake) systematically open a
> >         console window (both with Qt and GTK GUI) whatever my console
> >         window setting.
> >         This does not happen when I compile locally the same release
> >         with nmake. I have not installed CMake yet on my machine to
> >         cross check, but it seems that we still have discrepancies
> >         between nmake and CMake.
> >
> >
> >
> >     This is down to the subsystem type.  The nmake builds are marked as
> >     "Windows Gui" and the CMake builds as "Windows Console".  It's a
> >     linker flag, supplied in $(guiflags) for nmake builds (or
> >     $(conflags) for command line programs e.g. tshark.exe).
> >
> >     I think CMake requires a set_target_properties(target_name
> >     PROPERTIES LINK_FLAGS "/SUBSYSTEM:WINDOWS") call for each gui target.
> >
> >
> > Indeed, it's something I explicitly added to andoiddump.exe to improve
> > the user experience and I did not even realize it could be the same thing :)
> >
> > Thanks Graham !
> >
> >
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
>
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe