Re: Buildbot test failures - wslua

[Pascal Quantin <pascal.quantin () gmail com>]

2015-03-11 17:19 GMT+01:00 Alexis La Goutte <alexis.lagoutte () gmail com>:

> On Wed, Mar 11, 2015 at 4:53 PM, Graham Bloice <
> graham.bloice () trihedral com> wrote:
>
> > The current test failures are in the wslua tests, in the last part of
> > the wslua_step_dissector_test() test, where the two files differ,
> > apparently testing old and new style tcp dissection.
> >
> > It seems the testin.txt file has multiple entries "[PDU Size: 64]" for
> > the reassembled packets pdu's, e.g. Frame 2, but testout.txt doesn't.
> >
> > I'm not sure what's caused the issue though.
> >
> > Hi,
>
> I think coming from Pascal patch about fix tcp.pdu.size (
> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75e8d91fd6aed4c13eafbf044f4d87b877d503bc
> )
Hi all,

yes I was about to denounce me but Alexis beat me :). This is a side effect
of the fix for bug 11007 where the addition of the PDU size item was broken
since some time.
I know that Peter is debating the usefulness of this field. In the meantime
we should fix the test suite to pacify the buildbot.
I can give it a try tonight but if someone is courageous enough to fix it
earlier, feel free.

Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe