Re: 2.0_rc2 - was GIOP dissector reply decode

[Andy Ling <Andy.Ling () s-a-m com>]

I’m moving forward with getting a 2.0 build working, but a quick comment….

I downloaded the prebuilt Windows installer for rc2 to try out. Running it up gave what appeared to be no window at all.
I eventually realised it had opened the window off screen. It was only by right clicking on the icon on the taskbar and 
selecting move that I could get it on screen.

This maybe because I am “upgrading” from 1.12. But something should really be checking the position is somewhere 
visible.

Regards

Andy Ling



From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Graham Bloice
Sent: Mon 02 November 2015 12:37
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] GIOP dissector reply decode

The Windows build for 2.0 has moved to CMake.  I'm in the process of submitting a change for the Developers Guide docs, 
but for now README.cmake in the top level source tree should have enough to get you going,

Nmake is still kind of supported, but nor for long.  The Win32.mak issue is detailed in the Developers Guide setup: 
https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html#ChSetupMSVC

On 2 November 2015 at 12:10, Andy Ling <Andy.Ling () s-a-m com<mailto:Andy.Ling () s-a-m com>> wrote:
> Couple of thoughts from a quick skim of the code/git history:

> 1. I presume giop_complete_request_list is for matching request/reply.
>  Grepping its use will probably give you some clues as to where to look.

Thanks for the pointer. Rummaging in packet-giop.c it looks like requests and replies are stored
in a hash table giop_complete_reply_hash and the key used for this is packet_info->fd->num

Does that look right, am I on the right track?

If so, then I guess I need to look at where this number comes from and if it is
used for anything else. Any help anyone?

> 2. I'd recommend using the latest dev branch (master or at least master-2.0).
>  Any fixes you find would need to be applied there (master) first and then backported to 1.12 (and 2.0)

I had a quick look at 2.0. So far I've fallen over at the first hurdle. I tried following
the build instructions and the first nmake -f Makefile.nmake verify_tools fails
with a file win32.mak not found error. So I guess I'm looking at the wrong instructions.

Can someone point me at how to build 2.0 for Windows.

Thanks

Andy Ling


--
Graham Bloice
---------------------------------------------------------------------------------------
This email has been scanned for email related threats and delivered safely by Mimecast.
For more information please visit http://www.mimecast.com
---------------------------------------------------------------------------------------

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe