Re: Submitting a change to fix GIOP request reply association

[Andy Ling <Andy.Ling () s-a-m com>]

That was one of the pages I’d looked at. So I had a quick try and failed at the first hurdle.

It’s a shame there isn’t an easy way for a quick submission. I’m not sure I have the time to sort all this out.

Trying to do the clone I get…..

Cloning into 'wireshark'...
Could not create directory '/home/AndyL/.ssh'.
The authenticity of host '[code.wireshark.org]:29418 ([174.137.42.81]:29418)' can't be established.
RSA key fingerprint is SHA256:2pW2/O/N6IvNX0ivOEBNzz0ABc0qv6JpMvUz/4UBbzY.
Are you sure you want to continue connecting (yes/no)? yes
Failed to add the host to the list of known hosts (/home/AndyL/.ssh/known_hosts).
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

So where is it looking for my home directory. My \Users\AndyL directory does have a .ssh directory and it contains 
github_rsa & github_rsa.pub, which I assume are the keys.

Regards

Andy Ling


From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Graham Bloice
Sent: Thu 05 November 2015 13:23
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Submitting a change to fix GIOP request reply association


On 5 November 2015 at 13:14, Andy Ling <Andy.Ling () s-a-m com<mailto:Andy.Ling () s-a-m com>> wrote:
I have made some changes to packet-giop.c so that the request reply association problem previously mentioned checks IP 
address and port number. This appears to work for both 2.0 and 1.12. It would be nice to submit this for inclusion in 
the main code. Previously I would have created a Bugzilla report and attached the change, but it looks like this has 
all changed.

So what is the easiest way to submit this change?

I had a quick look at the git gerrit stuff and it looks like quite a hill to climb just for a one off submission.


Submissions should be as per the wiki page SubmittingPatches (https://wiki.wireshark.org/Development/SubmittingPatches).

While it may be a mountain to climb for a single submission, it's the only way the volunteer core developers can sanely 
even begin to handle the volume of submissions.

A Bugzilla entry with a capture illustrating the issue is always handy for verifying the changes.


--
Graham Bloice
---------------------------------------------------------------------------------------
This email has been scanned for email related threats and delivered safely by Mimecast.
For more information please visit http://www.mimecast.com
---------------------------------------------------------------------------------------

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe