Wireshark mailing list archives

Re: io.h include guards


From: Guy Harris <guy () alum mit edu>
Date: Thu, 5 Nov 2015 14:11:40 -0800


On Nov 5, 2015, at 1:44 PM, Graham Bloice <graham.bloice () trihedral com> wrote:

What's the best way to make this all consistent, fix CMake and the _WIN32 guards to use HAVE_IO_H, or change the docs 
and ascend_scanner to use _WIN32?

Fix ascend-scanner.l not to include io.h at all; the claim is that it's for isatty(), but:

        1) that's only used by interactive scanners;

        2) we use %option never-interactive, so the scanner shouldn't be interactive and shouldn't use isatty() on UN*X 
or Windows.

Fix README.developer to say that io.h is Windows-only and should be guarded with _WIN32.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: