Re: Petri-dish buildbot - not finding QtWidgets/QLabel

[Martin Mathieson <martin.r.mathieson () googlemail com>]

I uploaded another patch (no 8) to just include <QLabel> and added it
to the petri-dish (probably-doomed number 7 will run first...).
But I still don't understand why we get away with including
QtWidgets/QLabel in lots of other header files.  Should they be
changed too?

Regards,
Martin

On Wed, Sep 23, 2015 at 1:11 PM, Alexis La Goutte
<alexis.lagoutte () gmail com> wrote:
> Hi Martin,
>
> It is because Petri Dish use Qt 4.x...
> and we need to add only QLabel (#include <QLabel>), no need the QtWidgets..
>
> Regards,
>
> On Wed, Sep 23, 2015 at 1:55 PM, Martin Mathieson
> <martin.r.mathieson () googlemail com> wrote:
> > Hi,
> >
> > This must be something simple, but I'm trying to get a first version
> > of the new LTE MAC statistics dialog checked in
> > (https://code.wireshark.org/review/#/c/10578/).
> >
> > I'm getting this error:
> >
> > In file included from
> >
> > /home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/ui/qt/main_window_slots.cpp:113:0:
> >
> > /home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/ui/qt/lte_mac_statistics_dialog.h:28:28:
> > fatal error: QtWidgets/QLabel: No such file or directory
> >  #include <QtWidgets/QLabel>
> >
> > on the Ubuntu buildbot.  See
> >
> > https://buildbot.wireshark.org/petri-dish/builders/Ubuntu%20x86-64%20Petri%20Dish/builds/3323/steps/compile_4/logs/stdio
> >
> > QtWidgets/QLabel is included from lots of header files in ui/qt
> > without a problem... I did try adding QtCore/QVariant first, but I am
> > just guessing, and don't want just to add lots of random header files
> > to make it go away.  Anyone know how it really works?  I am building
> > on ubuntu x86-64 without problems using Qt 5.4.1.
> >
> > Thanks,
> > Martin
> >
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> >
> > mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
>
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe