Re: Trying to submit a patch

[Hadriel Kaplan <the.real.hadriel () gmail com>]

I just tried pushing with https, and it works. But of course you'll
still need a Change-ID and such. What *exact* error message are you
seeing?

Also, why would you submit something new into master-1.12?  We only do
bug fixes for 1.12, not new features. New features go in master (i.e.,
1.99.x).

-hadriel


On Tue, Sep 1, 2015 at 9:21 AM, John Dill <John.Dill () greenfieldeng com> wrote:
> I have finally got the time to port my changes to proto.h/proto.c over to the master-1.12 version of wireshark and 
> I'm getting stuck trying to submit a patch for review.
>
> I was not able to clone using the ssh method to download the latest git repo, but I was able to clone using the https 
> link.  I believe that the port 29418 is blocked by the IT firewall.  After checking out the 1.12 branch and making my 
> changes, I'm trying to submit a patch and can't seem to get it to go.
>
> Is it possible to submit a patch using something like the following
>
> git push https://user.name () code wireshark org/wireshark HEAD:refs/for/master-1.12/feature-request-display-options
>
> Or does submitting a patch require ssh?  I didn't see an equivalent for the https version in the developer's guide.
>
> Thanks,
> John D.
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe