Re: Building latest Wireshark using VS2013

[Pascal Quantin <pascal.quantin () gmail com>]

2016-12-23 10:52 GMT+01:00 João Valverde <joao.valverde () tecnico ulisboa pt>:

> I don't know much about MSVC but my best guess is broken C99 support.


If I"m not mistaken, version 12.0.21005 was the first MSVC 2013 version.
Since 5 updates were released and we have no issue compiling the Wireshark
code with MSVC 2013 Update 5. The download link can be found here:
https://www.microsoft.com/en-us/download/details.aspx?id=48129
Once upgraded, my bet is that no patch will be required.


> On 12/23/2016 08:51 AM, Andreas wrote:
>
> > I could "fix" the errors compiling the dissectors. This looks like a bug
> > in the VS2013 compiler I use. The function add_ipv6_address_teredo has
> > these lines:
> >
> >     if (tvb_get_ntohl(tvb, offset) != 0x20010000)
> >         return;
> >
> >     guint16 mapped_port = tvb_get_ntohs(tvb, offset + 10) ^ 0xffff;
> >
> > That's not accepted as a variable definition for 'mapped_port'. I could
> > make a workaround by changing the condition statement above:
> >
> >
> >     if (tvb_get_ntohl(tvb, offset) != 0x20010000)
> >     {    return;    }
> >
> > I have no idea why the compiler complains or why this helps. I assume
> > this is a bug with VS2013 Premium Version 12.0.21005.1 REL. The version
> > of the compiler binary is
> > Microsoft (R) C/C++ Optimizing Compiler Version 18.00.21005.1 for x64
> >
> >
> > If I enable detailed MSBUILD logs then I could identify a bit more with
> > the docbook problem. The detailed error message is
> >
> >    Der Befehl "LC_ALL" ist entweder falsch geschrieben
> >    oder konnte nicht gefunden werden.
> >
> > I assume this command should be executed with bash instead of cmd.exe,
> > what is the magic how commands are executed by cygwin bash instead of
> > the windows command processore?
> > Is it legal to set WIRESHARK_CYGWIN_INSTALL_PATH not pointing to
> > C:\cygwin?
> > How can I identify what commands are really executed in this build step?
> >
> > Regards
> > Andreas
> >
> > ____________________________________________________________
> > _______________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org?subject=unsubscr
> > ibe
> >
> > ____________________________________________________________
> _______________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe